Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify config #77

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Solidify config #77

merged 3 commits into from
Jul 20, 2023

Conversation

lippserd
Copy link
Member

  • Fixes PHP 8.2 dynamic properties deprecation warnings
  • Converts keys to camelCase

refs #67
refs #68
fixes #69

There are options that are specific to the database driver being used,
such as SSL settings, that cannot be represented by public properties
that should be common to all database drivers. Since dynamic properties
have been deprecated since PHP version 8.2, they are now set in a
separate array using magic methods. camelCasing for keys is done to
comply with our encoding standards.
@lippserd lippserd requested a review from nilmerg July 19, 2023 11:08
@nilmerg nilmerg added this to the v0.7.0 milestone Jul 19, 2023
@nilmerg nilmerg added the enhancement New feature or request label Jul 19, 2023
@nilmerg
Copy link
Member

nilmerg commented Jul 19, 2023

@clabot check

@cla-bot cla-bot bot added the cla/signed label Jul 19, 2023
@lippserd lippserd merged commit d3d1413 into main Jul 20, 2023
@lippserd lippserd deleted the solidify-config branch July 20, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dynamic Properties are deprecated in PHP 8.2
2 participants