New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add app, app bar and back button #128
Conversation
I have added a I also need to add the boxShape on the app bar fields for the button to use that one automatically if specify like we talk earlier, but same I'll do it in another PR. This one is good to me, let me know what you think |
I have removed |
I see you're doing a lot of changed in this PR, I'll wait until you tell me to review before opening it :) |
Yes sorry for that :) I'll not touch it more except to fix your comments. So you can review it. |
Ok :) I start review it so ! do you have created a sample ? |
yes : |
I think the sample should stay in light mode, my computer is in dark mode & it's ugly here :) we'll add then add
into playground, because the scaffold background color is wierd |
if the
for example (i'm not sure of the arg name) |
Oh i forgot, thanks for this MR, the app & appbar implem (fork / wrap of material) is really great ! |
NeumorphicBackButton is perfect :) |
Right I didn't test in dark mode ^^
There is no need as it's what is done under NeumorphicApp already :)
Yeah that's the non finished part I was talking about, the idea here is to have a NeumorphicAppBarTheme where you can configure a
No problem it was cool to do :) |
I have pushed Do you need me to do anymore changes on this ? |
Nope I try again & will merge this :) |
I merge it :) If we have futher work we will do this on master or others PR |
fix #122
I also removed
UsedTheme
to use the existingThemeMode