fix: Ignore extra parameters on UserInfo + test #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdecock
reviewed
Feb 2, 2024
| clone.ClientSecret = string.Empty; | ||
| clone.ClientAssertion = new ClientAssertion(); | ||
| clone.Parameters = new Parameters(); | ||
|
|
||
| clone.Method = HttpMethod.Get; |
There was a problem hiding this comment.
It seems like the real issue is that the method is always a GET even if there is content in the form of client auth or other parameters. I think it is probably confusing to discard those extra parameters, and so if we want that to not be allowed at all, then it should be an explicit error, and the fundamental problem is the fact that it is always a GET. (Spec does allow POST).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore extra parameters on UserInfo + test
base on #255