Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute filtering #423

Merged
merged 5 commits into from Jul 11, 2017
Merged

Commits on Jun 12, 2017

  1. Add failing test for filtering attributes

    Added a test that fails when the friendlyName of the requested attribute
    is not the same with the name of the internal attribute (even though the
    OIDs and the internal representation names of the attribute are the same)
    jkakavas committed Jun 12, 2017
    Copy the full SHA
    9d0cc9c View commit details
    Browse the repository at this point in the history
  2. Base attribute filtering on internal representation names

    Instead on relying on the FriendlyName from metadatata, use the name
    of the internal representation of an attribute in order to perform
    filtering. Resolves IdentityPython#422
    jkakavas committed Jun 12, 2017
    Copy the full SHA
    c24b47c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2017

  1. Updated test cases

    As explained in
    IdentityPython#423 (comment) , ava
    cannot contain an 'surName' key, it should be named 'sn'
    jkakavas committed Jun 13, 2017
    Copy the full SHA
    695e2f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2017

  1. Minor fixes

    jkakavas committed Jul 5, 2017
    Copy the full SHA
    5bcb6ac View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2017

  1. Modified test cases to include acs in the args

    Since acs can't be None ( it get's a value in __init__()
    https://github.com/rohe/pysaml2/blob/master/src/saml2/assertion.py#L319)
    there is no reason to test for it. So we add a default value to acs
    using ac_factory() before passing it to filter_on_attributes
    jkakavas committed Jul 6, 2017
    Copy the full SHA
    f00e0dd View commit details
    Browse the repository at this point in the history