New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle all types of ACS endpoint specifications #757
Handle all types of ACS endpoint specifications #757
Conversation
33685c5
to
f6ebe31
Compare
The SP authnReq now works with a 3-tuple (URL+binding+index) ACS service conf
f6ebe31
to
9b4b70f
Compare
TODO: |
I think this is correct. |
I agree, and looking at that code ... Hundreds of nested if statements in a generic try/except... In a for loop. We'll die crazy... That function could be entirely refactored. |
And not at last, we shouldn't return sometimes a string and sometimes a tuple. Let's return a tuple and anything else ... Let's refactor that function, it's too noisy |
@c00kiemon5ter you approved this, is it time to merge or do we have to put in also the unit test, before? |
With these changes a SP ACS service configured with a 3-tuple
(URL, binding, index)
works correctly.Fixes #599
All Submissions: