Changing cake file to skip versioning on non-Windows (#2637)

Changing cake file to skip versioning on non-Windows
IdentityServer · Sep 22, 2018 · f587504 · f587504
1 parent e60d524
commit f587504
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 32 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,7 @@
 ## Ignore Visual Studio temporary files, build results, and
 ## files generated by popular Visual Studio add-ons.
 
+
 # User-specific files
 *.suo
 *.user

diff --git a/build.cake b/build.cake
@@ -36,45 +36,55 @@ class VersionInfo
 
 Setup(context =>
 {
-    var gitVersions = Context.GitVersion();
-
-    versions = new VersionInfo
+    // only calculate versions if on Windows
+    // due to problems with GitVersion in the current setup - but also since Windows is our release platform anyways
+    if (isWindows)
     {
-        InformationalVersion = gitVersions.InformationalVersion,
-        BranchName = gitVersions.BranchName,
-        PreReleaseLabel = gitVersions.PreReleaseLabel
-    };
+        var gitVersions = Context.GitVersion();
+
+        versions = new VersionInfo
+        {
+            InformationalVersion = gitVersions.InformationalVersion,
+            BranchName = gitVersions.BranchName,
+            PreReleaseLabel = gitVersions.PreReleaseLabel
+        };
 
-    // explicit version has been passed in as argument
-    if (!string.IsNullOrEmpty(versionOverride))
-    {
-        versions.AssemblyVersion = versionOverride;
-        versions.FileVersion = versionOverride;
+        // explicit version has been passed in as argument
+        if (!string.IsNullOrEmpty(versionOverride))
+        {
+            versions.AssemblyVersion = versionOverride;
+            versions.FileVersion = versionOverride;
 
-        if (!string.IsNullOrEmpty(suffixOverride))
+            if (!string.IsNullOrEmpty(suffixOverride))
+            {
+                versions.VersionSuffix = suffixOverride;
+            }
+        }
+        else
         {
-            versions.VersionSuffix = suffixOverride;
+            versions.AssemblyVersion = gitVersions.AssemblySemVer;
+            versions.FileVersion = gitVersions.AssemblySemVer;
+
+            if (!string.IsNullOrEmpty(versions.PreReleaseLabel))
+            {
+                versions.VersionSuffix = gitVersions.PreReleaseLabel + gitVersions.CommitsSinceVersionSourcePadded;      
+            }
+
         }
+
+        Information("branch            : " + versions.BranchName);
+        Information("pre-release label : " + versions.PreReleaseLabel);
+        Information("version           : " + versions.AssemblyVersion);
+        Information("version suffix    : " + versions.VersionSuffix);
+        Information("informational     : " + versions.InformationalVersion);
+
+        msBuildSettings = GetMSBuildSettings();
     }
     else
     {
-        versions.AssemblyVersion = gitVersions.AssemblySemVer;
-        versions.FileVersion = gitVersions.AssemblySemVer;
-
-        if (!string.IsNullOrEmpty(versions.PreReleaseLabel))
-        {
-            versions.VersionSuffix = gitVersions.PreReleaseLabel + gitVersions.CommitsSinceVersionSourcePadded;      
-        }
-
+        Information("Skipping version calculation because not on Windows.");
+        msBuildSettings = null;
     }
-
-    Information("branch            : " + versions.BranchName);
-    Information("pre-release label : " + versions.PreReleaseLabel);
-    Information("version           : " + versions.AssemblyVersion);
-    Information("version suffix    : " + versions.VersionSuffix);
-    Information("informational     : " + versions.InformationalVersion);
-
-    msBuildSettings = GetMSBuildSettings();
 });
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -99,13 +109,18 @@ Task("Build")
         MSBuildSettings = msBuildSettings
     };
 
-    
     var projects = GetFiles("./src/**/*.csproj");
     foreach(var project in projects)
 	{
 	    DotNetCoreBuild(project.GetDirectory().FullPath, settings);
     }
 
+    if (!isWindows)
+    {
+        Information("Not running on Windows - skipping building tests for .NET Framework");
+        settings.Framework = "netcoreapp2.1";
+    }
+
     var tests = GetFiles("./test/**/*.csproj");
     foreach(var test in tests)
 	{
@@ -130,7 +145,7 @@ Task("Test")
     if (!isWindows)
     {
         Information("Not running on Windows - skipping tests for .NET Framework");
-        settings.Framework = "netcoreapp2.0";
+        settings.Framework = "netcoreapp2.1";
     }
 
     var projects = GetFiles("./test/**/*.csproj");
@@ -163,6 +178,12 @@ Task("Pack")
 
 private bool SkipPack()
 {
+    if (!isWindows)
+    {
+        Information("Skipping pack because not on Windows.");
+        return true;
+    }
+
     if (String.IsNullOrEmpty(versions.PreReleaseLabel) && versions.BranchName != "master") 
     {
         Information("Skipping pack of release version, because not on master.");