This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Fixed bug where the Subject was not being set on the ValidatedRequest and would not end up in the TokenIssuedSuccessEvent using Code flow #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the Code flow. As a result, we didn't have visibility in the event handlers as to which subject the event was for.
brockallen
added a commit
that referenced
this pull request
Apr 30, 2019
…uedSuccessEvent using Code flow #3059
|
Given the merge conflicts, we added this manually. Thanks. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
When the TokenIssuedSuccessEvent is raised on a successful code authorization, the SubjectId field is blank because the Subject property was not being set in the ValidatedRequest class. It gets set on the other authorization flows, but the line to set it here was missing.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: