Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Fix UserLoginFailureEvent raised with interactive=true in resource owner grant flow #4240

Merged
merged 2 commits into from
May 7, 2020
Merged

Fix UserLoginFailureEvent raised with interactive=true in resource owner grant flow #4240

merged 2 commits into from
May 7, 2020

Conversation

ArturDorochowicz
Copy link
Contributor

What issue does this PR address?
Fixes #4172. UserLoginFailureEvent is incorrectly raised with interactive=true in resource owner grant flow processing in TokenRequestValidator.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:

@brockallen brockallen added this to the 4.0 milestone Apr 1, 2020
@brockallen brockallen modified the milestones: 4.0, 3.1.3, 3.1.4 May 7, 2020
@brockallen brockallen added bug and removed pinned labels May 7, 2020
@brockallen brockallen merged commit 3d370dc into IdentityServer:releases/3.1.x May 7, 2020
@brockallen
Copy link
Member

Thanks!

brockallen pushed a commit that referenced this pull request May 7, 2020
@ArturDorochowicz @brockallen
Fix UserLoginFailureEvent raised with interactive=true in resource ow…
19540d4 
…ner grant flow (#4240)

* Fix UserLoginFailureEvent raised as interactive

* Improve readability - add parameter name

Co-authored-by: Artur Dorochowicz <artur@dorochowicz.com>
(cherry picked from commit 3d370dc)
@ArturDorochowicz ArturDorochowicz deleted the resown branch May 7, 2020 15:41
@github-actions
Copy link

github-actions bot commented May 7, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturDorochowicz @brockallen