-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Bold, Italic, and Thin Variants #128
Conversation
Font generation can be really slow, especially now with continuous ligatures, and this will slow it down 3x, if I understand the code. Maybe it would be a good idea to separate each variant generation into it's own thread? So that the slow down is not that bad. I don't have much experience with python, but form what I found it seems to be relatively easy |
It gets a bit better with manually transforming bold glyph. But now there is really nasty segfault which i can't fix. I've commented out the offending line for now. |
Very cool! What are the current issues that still need to be fixed? |
Boldness needs to be ajdusted, i'm still trying to find a middle point. And i didn't test for all character, some might gets unreadable with bold. Also i don't know if putting all fonts into |
I've tried it out. For my usecase, in the terminal, the bold might be too thick. Which conflicts with @SirMishaa's opinion who thinks it needs to be thicker. |
I can make it multiple level of boldness/thinness. Trouble is, build time multiplies with each new variant. Another thing is i haven't had any algorithm for thinning, particularly with diagonals. |
I don't think build time is that much of an issue. My laptop compiles your branch in 30 seconds, and most people download the font pre-built. I am curious what @IdreesInc's opinion is on that. |
I personally agree, while long build times are annoying when you're trying to quickly iterate on a glyph(s) for most people it's not an issue. Maybe add a flag to disable generation of additional fonts, to allow to iterate faster? if that's the concern. |
Look, if the font you use doesn't take a few days to generate, is it even a real font? Update: Generates relatively quickly on my modern machine and with the new flags allowing people to skip generation of certain variants it should be fine. |
Wow, this is fantastic, thanks @Dheatly23 for adding this in! Apologies for the delay in reviewing it, been working on many new projects at once and haven't had the time to review new features in stable projects until now. |
The weights look good to me on the mac (though the super light weight doesn't connect, but not much that can be done there). Will check out on my Windows machine when I get home and hopefully get this PR merged this weekend! Also love the concept of the .ttc thing, never realized you could bundle font files that way. Any idea if that will work on Windows/Linux as well? |
Implements #127. Still needs to fix lag somehow. And maybe package all variants in a single file?
Example:
![Example](https://private-user-images.githubusercontent.com/71598333/251805237-19291389-0c34-4ddb-b728-01eed6241a3c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NTg1MTMsIm5iZiI6MTcyNDQ1ODIxMywicGF0aCI6Ii83MTU5ODMzMy8yNTE4MDUyMzctMTkyOTEzODktMGMzNC00ZGRiLWI3MjgtMDFlZWQ2MjQxYTNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAwMTAxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY1Mjg0OWY2NzQwMmMxMzg5MDQ3NzFlNDU0N2JkNTJlMDQ2NzUwM2IzYWFhNGNkMzAwNDQzYjhlNThiYTJhMDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2k04hqRUPbUsAps47gBy8uGhBAvRhniCEP4CmTSgxoM)
(size: 10 pt)
(in order: Regular, Italic, Bold, Bold Italic):