Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlangeEdgeRadius and FlangeSlope for IfcIShapeProfileDef #2631

Closed
theoryshaw opened this issue Dec 5, 2022 · 2 comments
Closed

FlangeEdgeRadius and FlangeSlope for IfcIShapeProfileDef #2631

theoryshaw opened this issue Dec 5, 2022 · 2 comments
Assignees
@Moult
Labels
IfcOpenShell-Core

Comments

@theoryshaw
Copy link
Member

Looks like flange rounding and sloping is not working as expected...

https://community.osarch.org/discussion/1272/flangeedgeradius-and-flangeslope-for-ifcishapeprofiledef
@Moult
Copy link
Contributor

Moult commented Jan 5, 2023

Yeah it looks as though this hasn't been implemented in IfcIShapeProfileDef.cpp. Perhaps some code can be taken from IfcUShapeProfileDef.cpp and maybe with a minor tweak it might just work. I have a new computer though so it might be a while until I get a chance to try.

Maybe @aothms can do it with his eyes closed :)

@Moult Moult self-assigned this Jan 8, 2023
Moult added a commit that referenced this issue Jan 8, 2023
@Moult
Fix #2631. Add support for flange edge radius and flange slope for I-…
a796e3b 
…shapes.
@Moult
Copy link
Contributor

Moult commented Jan 8, 2023

Seems to work on my end but given I suck at C++ @aothms should review it :)

2023-01-08-211218_801x598_scrot

@aothms aothms closed this as completed in ed37d11 Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Moult Moult

Labels
IfcOpenShell-Core
Projects
No open projects
BlenderBIM Add-on v0.0.230304 (themes: bugfixing, 4D)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Moult @theoryshaw