Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window voids Slabs in a weird way #4377

Closed
bdamay opened this issue Feb 29, 2024 · 1 comment
Closed

Window voids Slabs in a weird way #4377

bdamay opened this issue Feb 29, 2024 · 1 comment

Comments

@bdamay
Copy link
Contributor

bdamay commented Feb 29, 2024

As discussed here https://community.osarch.org/discussion/2002/irregular-walls#latest
If we select a window and a slab with angle and type "Apply void" the window rotates perpendicular to the plan of the slab instead of Opening the slab
image
image

@bdamay
Copy link
Contributor Author

bdamay commented Feb 29, 2024

I made a patch in model/opening.py (around line 100) that assumes the window should bear the void when affecting new_matrix variable

 if element.is_a("IfcSlab") and filling.is_a("IfcWindow"):
                # in this case i think new_matrix should be the filling obj
                # i also wonder in what case it shouldn't be the filling obj that opens the target
                # (in that last case we could unfilter this section ) 
                new_matrix = filling_obj.matrix_world.copy()

This seems to correct things but one have to position the window correctly before applying the void

shall i send a PR ? (i'm not sure of the way you want things done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants