Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pandas to makefile #2973

Closed
wants to merge 2 commits into from

Conversation

C-Claus
Copy link

@C-Claus C-Claus commented Apr 12, 2023

Is it possible to add pandas to ../../blenderbim/libs/site/packages?
Seems like an extremly useful python module, I am planning to incorporate blenderbim spreadsheet to blenderbim. It needs this module.

@C-Claus
Copy link
Author

C-Claus commented Apr 13, 2023

Next to pandas, I think the openpyxl module would be also useful?

@Moult
Copy link
Contributor

Moult commented Apr 13, 2023

I think you're right, sooner or later pandas would be a huge help in doing spreadsheet and cost related things.

But are you sure this link is correct? It seems to point to a source distribution (pandas-2.0.0.tar.gz) https://pypi.org/project/pandas/#files

BTW a better approach would be to use pip sort of like this https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.7.0/src/blenderbim/Makefile#L220 and specify the platform flag https://stackoverflow.com/questions/45980037/how-to-download-pip-packages-for-a-different-operating-system

@Moult
Copy link
Contributor

Moult commented Apr 13, 2023

I also agree about openpyxl. IfcCSV currently uses xlsxwriter but I think that's a bad idea (it only writes) and recently I've been using openpyxl more and find it much more capable.

@C-Claus
Copy link
Author

C-Claus commented Apr 13, 2023

@Moult Thanks for your reply, I have no experience with makefiles. I will look into into and try to find the correct way of adding it.

I've been using openpyxl more and find it much more capable.

I've came to the same conclusion when writing BlenderBIM spreadsheet.

@C-Claus
Copy link
Author

C-Claus commented Jul 5, 2023

After reading this post, https://community.osarch.org/discussion/comment/16243/#Comment_16243

I guess this PR can be closed?

It says pandas is now included.

@Moult
Copy link
Contributor

Moult commented Jul 6, 2023

Ah thanks for reminding me about this. Pandas isn't included in BBIM, but if you have Pandas you can use it via a library in IfcCSV as described here https://blenderbim.org/docs-python/ifccsv.html#source-installation

I still can't approve this pull request as it isn't quite right since:

  1. It includes Brick.ttl, which we shouldn't store in the repo
  2. It doesn't handle multiple platforms, ideally we should do this via pip install with a platform argument

Would you like to make those changes? Alternatively I can just commit. Is pandas needed for openpyxl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants