proposed fix for #744 #801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason travis fails. I am not sure what caused travis to fail ?!? |
|
Many thanks for this @sanderboer. Sorry for the long delay in replying. I'm not entirely sure, but I'm guessing [0] the return of fmod() could be negative in this case, so we probably need to wrap it in std::abs() (which is what ALMOST_THE_SAME also would have done. |
aothms
added a commit
that referenced
this pull request
May 20, 2020
|
I went with a slightly different fix, but many thanks for the investigations. d811963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue with #744 is that some programs export full circles as trimmed circles, with trimparams at 0 and 2*pi. But due to floating point precision this trim could flip from full circle to an infinitesimally small line segment.