linux-dmabuf: Pass the correct enum for each plane #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that slipped in the first submission of Linux DMA buffer support. Only plane zero attributes were being given to eglCreateImage(). The issue was only uncovered now as we tested screens and drivers that support more than one buffer plane.
zdobersek
approved these changes
Jun 14, 2018
aperezdc
approved these changes
Jun 14, 2018
There was a problem hiding this comment.
LGTM, and also tested applying Igalia/cog#28 locally — this indeed makes graphics output work well again when using DMA-BUF.
JPEWdev
pushed a commit
to JPEWdev/WPEBackend-fdo
that referenced
this pull request
Jul 24, 2019
…er-init Add wpe_loader_init()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that slipped in the first submission of Linux DMA buffer support. Only plane zero attributes were being given to eglCreateImage(). The issue was only uncovered now as we tested screens and drivers that support more than one buffer plane.