Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdo: Explicitly set the backend implementation name #60

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

aperezdc
Copy link
Member

@aperezdc aperezdc commented Sep 3, 2018

Fixes #11

Copy link
Contributor

@elima elima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this. It forced me to re-build a more recent version of WK and libwpe, to be able to test it.

I have done that now and it works nicely. Code looks good.

Thanks!

@elima elima merged commit 56401ee into master Sep 6, 2018
@elima elima deleted the fdo-libname branch September 6, 2018 06:26
@elima
Copy link
Contributor

elima commented Sep 6, 2018

Merged.

@aperezdc
Copy link
Member Author

aperezdc commented Sep 6, 2018

@elima No problem at all. Thanks for taking the time for testing the patch, having to rebuild WPE WebKit is a chore after all!

psaavedra added a commit to Igalia/meta-webkit that referenced this pull request Nov 14, 2018
…link

* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version.
* Note: This is will not the case of libwpe package. Since WPE 2.22.x,
  it won't be needed anymore (Igalia/cog#60),
  it is recommended to set the implementation library name using the
  libwpe API like this instead of having the ugly symlink.
psaavedra added a commit to Igalia/meta-webkit that referenced this pull request Nov 14, 2018
* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version.
* Note: This is will not the case of libwpe package. Since WPE 2.22.x,
  it won't be needed anymore (Igalia/cog#60),
  it is recommended to set the implementation library name using the
  libwpe API like this instead of having the ugly symlink.
psaavedra added a commit to Igalia/meta-webkit that referenced this pull request Nov 14, 2018
* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version.
* Note: This is will not the case of libwpe package. Since WPE 2.22.x,
  it won't be needed anymore (Igalia/cog#60),
  it is recommended to set the implementation library name using the
  libwpe API like this instead of having the ugly symlink.
psaavedra added a commit to Igalia/meta-webkit that referenced this pull request Nov 14, 2018
* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version.
* Note: This is will not the case of libwpe package. Since WPE 2.22.x,
  it won't be needed anymore (Igalia/cog#60),
  it is recommended to set the implementation library name using the
  libwpe API like this instead of having the ugly symlink.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants