-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fdo: Explicitly set the backend implementation name #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay reviewing this. It forced me to re-build a more recent version of WK and libwpe, to be able to test it.
I have done that now and it works nicely. Code looks good.
Thanks!
Merged. |
@elima No problem at all. Thanks for taking the time for testing the patch, having to rebuild WPE WebKit is a chore after all! |
…link * wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version. * Note: This is will not the case of libwpe package. Since WPE 2.22.x, it won't be needed anymore (Igalia/cog#60), it is recommended to set the implementation library name using the libwpe API like this instead of having the ugly symlink.
* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version. * Note: This is will not the case of libwpe package. Since WPE 2.22.x, it won't be needed anymore (Igalia/cog#60), it is recommended to set the implementation library name using the libwpe API like this instead of having the ugly symlink.
* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version. * Note: This is will not the case of libwpe package. Since WPE 2.22.x, it won't be needed anymore (Igalia/cog#60), it is recommended to set the implementation library name using the libwpe API like this instead of having the ugly symlink.
* wpebackend-fdo 0.1 version is used by wpewebkit 2.20 version. * Note: This is will not the case of libwpe package. Since WPE 2.22.x, it won't be needed anymore (Igalia/cog#60), it is recommended to set the implementation library name using the libwpe API like this instead of having the ugly symlink.
Fixes #11