wl: Add safe-guards for touch and pointer events #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
force-pushed
the
psaavedra/wl-Add-safe-guards-for-touch-and-pointer-events
branch
2 times, most recently
from
e8a742d
to
3b76948
Compare
In some unstable compositors it could be possible these 2 cases: * to receive touch up/motion events immediatelly after a touch up (touch deinit the touch target). * to receive pointer motion/leave event immediatelly after a touch leave (deinit the touch target).
psaavedra
force-pushed
the
psaavedra/wl-Add-safe-guards-for-touch-and-pointer-events
branch
from
3b76948
to
26cf220
Compare
aperezdc
approved these changes
Mar 27, 2024
| @@ -271,8 +271,14 @@ pointer_on_enter(void *data, | |||
| static void | |||
| pointer_on_leave(void *data, struct wl_pointer *pointer, uint32_t serial, struct wl_surface *surface) | |||
| { | |||
| if (data == NULL || pointer == NULL) | |||
There was a problem hiding this comment.
In general it's not needed to explicitly compare with NULL, which tends to be clearer:
Suggested change
| if (data == NULL || pointer == NULL) | |
| if (!data || !pointer) |
aperezdc
deleted the
psaavedra/wl-Add-safe-guards-for-touch-and-pointer-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some compositors it could be possible these 2 cases:
This patch adds safeguards in the touch events callbacks