Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpage to scroll to the new/cloned task #148

Closed
jaragunde opened this issue Mar 9, 2016 · 5 comments
Closed

Webpage to scroll to the new/cloned task #148

jaragunde opened this issue Mar 9, 2016 · 5 comments

Comments

@jaragunde
Copy link
Member

[Trac import]
Reported by: agomez
Original date: Thursday, 28 July 2011 12:48

Everytime you click on "new" or "clone" the usual use case is to save or edit the added task. Hence, the user will scroll to the task at the end of the page 99% of times.

It would be great if, in addition to creating this new/cloned task, the webpage scrolls to the proper place too.

@jaragunde
Copy link
Member Author

[Trac import]
Comment by: jaragunde
Original date: Monday, 01 December 2014 11:49

Replying to [ticket:148 agomez]:

It would be great if, in addition to creating this new/cloned task, the webpage scrolls to the proper place too.

This is the current behaviour of the application. When a new task is created, focus is placed on its init date and the webpage scrolls if necessary.

@jaragunde
Copy link
Member Author

[Trac import]
Comment by: agomez
Original date: Monday, 01 December 2014 12:05

Replying to [comment:1 jaragunde]:

This is the current behaviour of the application. When a new task is created, focus is placed on its init date and the webpage scrolls if necessary.

Just checked and it is almost working as described.

Don't know if the behavior was always like that or it is a problem just with WKGTK 2.6.x and Ephy 3.14.x

When you create the first task that it goes out of the height, the scroll doesn't move to show the new task completely if the date for the new task getting the focus fits in the remaining free space at the bottom. Only when a new/cloned task is completely out of view the scroll works so it shows the new task fully.

This is kind of annoying and, although a minor problem, it would be great if it could be fixed.

@jaragunde
Copy link
Member Author

[Trac import]
Comment by: jaragunde
Original date: Monday, 01 December 2014 14:34

Replying to [comment:2 agomez]:

When you create the first task that it goes out of the height, the scroll doesn't move to show the new task completely if the date for the new task getting the focus fits in the remaining free space at the bottom. Only when a new/cloned task is completely out of view the scroll works so it shows the new task fully.

You are right, I hadn't checked that case.

@jaragunde
Copy link
Member Author

[Trac import]
Comment by: jaragunde
Original date: Monday, 01 December 2014 14:34

commit 5c998c576935d8989ac8931a8756a941f5f977de
Author: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Date:   Mon Dec 1 14:32:27 2014 +0100

    [#148] Explicitly set scroll in the newly added task

@jaragunde
Copy link
Member Author

[Trac import]
Comment by: agomez
Original date: Monday, 01 December 2014 14:46

Nice! Hope to see it soon in beta* :)

jaragunde added a commit that referenced this issue May 30, 2018
As part of #323, the menubar div took the space of the header but the
calculation of HEADER_HEIGHT was not modified. Later, the empty header
was removed and the error started happening at
25b50a4.

Fixes regression on #148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant