Port City DAO to use PDO #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also remove unnecessary checks for row id in update and delete operations.
This was used only inside the DAO, and we remove any uses of it. We would re-add the function if we ever need it.
If constructor is missing, parent's will be called. No need to do that explicitly. In PostgreSQLCityDAO the constructor is still necessary because it needs to overwrite the BaseDAO constructor visibility.
Remove setValues() too, which was the last used in getAll() (through BaseDAO::execute()).
This operation is never used; upper layers use CommonEventDAO::getByCityId instead.
|
pinging @dmtrek14 so you can start reviewing too :) I don't expect you to understand everything, feel free to ask questions and use this PR to learn. |
dmtrek14
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
@jaragunde and @anarute All of this looks good to me and looks like good code cleanup. I've done some testing locally to confirm there are no regressions and everything works well here.
anarute
approved these changes
Jan 13, 2023
|
Thanks for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #513, also includes a patch for #431, removes unused code and fixes some defects.