Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing intel_mp RX/TX counters does not seem to work properly on latest release #1137

Closed
takikawa opened this issue Jul 3, 2018 · 1 comment
Closed

Sharing intel_mp RX/TX counters does not seem to work properly on latest release #1137

takikawa opened this issue Jul 3, 2018 · 1 comment
Labels
v2018.04.03

Comments

@takikawa
Copy link
Member

takikawa commented Jul 3, 2018

On intel_mp, it is possible to share RX and TX counters since there are fewer counters than possible queues in use. This doesn't seem to work properly on the current Snabb lwAFTR release if both apps use run_stats = true (as lwAFTR's setup.lua does) and the same counter.

I think this shows a problem with the approach of having each app sync its own queues. The accumulating counters for an intel_mp app are local to the app object, while the NIC's counter registers reset on each read.
This was referenced Jul 3, 2018
Merged
Closed
@dpino dpino mentioned this issue Jul 6, 2018
Closed
7 tasks
@takikawa
Copy link
Member Author

This should now work correctly with #1148 merged. #1138 adds a test to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2018.04.03
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpino @takikawa