Adjust new queue stats accounting to work with original run_stats semantics #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run_stats config flag tells which instance should update the counters generally. This commit refactors the queue stats handling so that the rx/tx counters are always updated regardless of whether run_stats is used or not. Only these counters are updated unless the app is the run_stats instance. Also avoid updating the link_status, etc counters in each app since those are global to the NIC
|
This approach had some flaws that makes it not worth merging. I will look into making a separate PR with some of the test changes which might be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the queue stats syncing so that RX/TX queue counters are always synced, ignoring
run_stats. This addresses issue #1139.Unfortunately, I think #1137 is still broken on this PR so I don't think it should be merged as-is. I'm concerned that having queue stats synced on separate apps is not actually going to work out in the end.