Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The semantics of run_stats is changed in the latest lwAFTR release #1139

Closed
takikawa opened this issue Jul 3, 2018 · 1 comment
Closed

Comments

@takikawa
Copy link
Member

takikawa commented Jul 3, 2018

Something I noticed after the release is that run_stats for intel_mp now means something slightly different than what it's intended to mean. In the docs, the run_stats option has this description:

Boolean indicating if this app instance should collect device statistics. One per physical NIC (conflicts with master_stats). There is a small but detectable run time performance hit incurred. The default is false.

In particular, each physical NIC should only have one app with the flag on. In the latest lwAFTR, we use the flag on multiple apps at once on a single NIC.

Instead, I think we should have NIC apps always sync their own RX/TX counters (regardless of what run_stats is) or maybe return to having one app always sync the stats (and find another way to show the queue counters in snabb top).

@takikawa
Copy link
Member Author

Fixed by #1148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants