Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no curved window in full-screen video mode #1055

Closed
xnuamx opened this issue Oct 9, 2023 · 6 comments · Fixed by #1057
Closed

There is no curved window in full-screen video mode #1055

xnuamx opened this issue Oct 9, 2023 · 6 comments · Fixed by #1057
Labels
enhancement New feature or request

Comments

@xnuamx
Copy link

xnuamx commented Oct 9, 2023

Configuration

Wolvic version: 1.5
Wolvic build ID:

Hardware: Oculus Quest 2

Steps to Reproduce

  1. Install wolvic
  2. Activate curved screen mod in settings
  3. Switch to full-screen mode in youtube or other app

Current Behavior

When switching to full-screen mode, the window stops being curved

Expected Behavior

In version 1.4.2, there is no such problem, when switching to full-screen mode, the window remains curved

Possible Solution

Context

Error Logs and Stack Traces

@HollowMan6
Copy link
Collaborator

This is the intended behavior to fix the 3D video playing when the curved window is enabled #969

Do you have a strong demand for playing 2D video in curved fullscreen? If that's the case, we may reconsider by adding an exception for that.

@HollowMan6 HollowMan6 self-assigned this Oct 9, 2023
@HollowMan6 HollowMan6 added the enhancement New feature or request label Oct 9, 2023
@xnuamx
Copy link
Author

xnuamx commented Oct 9, 2023

That's right, I use wolvic to view 2D video content, it's very convenient for me. And in the curved screen mode, the picture is perceived much better, if there is such an opportunity to return the curved screen for 2D mode, it would be super!

HollowMan6 added a commit that referenced this issue Oct 9, 2023
Only disable curved screen when it's playing front facing 3d VR videos

Resolve #1055

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
@HollowMan6 HollowMan6 removed their assignment Oct 9, 2023
@GuerreroNinja
Copy link

GuerreroNinja commented Oct 9, 2023

I am using the app lab version (1.4.1) due to this issue. Is it possible to add an option to keep the screen curved in fullscreen? Thank you.

@GuerreroNinja
Copy link

Oh I just saw the pull request, than you @HollowMan6 !!

svillar pushed a commit that referenced this issue Oct 10, 2023
Only disable curved screen when it's playing front facing 3d VR videos

Resolve #1055

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
@HollowMan6
Copy link
Collaborator

Sorry to you guys! Didn't realize that people would actually want to watch full-screen video in curved windows when I worked on the original PR: #969

@HollowMan6
Copy link
Collaborator

The next version should fix this issue.

felipeerias pushed a commit that referenced this issue Oct 16, 2023
Only disable curved screen when it's playing front facing 3d VR videos

Resolve #1055

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias pushed a commit that referenced this issue Oct 17, 2023
Only disable curved screen when it's playing front facing 3d VR videos

Resolve #1055

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants