Fix several issues related to VR videos playing #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only disable curved screen when it's playing front facing 3d VR videos Resolve #1055 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
So that we won't have a crash when user reselect 2D projection when we are already playing in 2D full screen mode. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
|
high priority because of commit 2315460 |
svillar
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only disable the curved screen when it's playing front facing 3d VR videos
Resolve #1055
So that we won't have a crash when the user reselects 2D projection and we are already playing in 2D full-screen mode.