Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PicoXR] Use GL_COMPRESSED_RGB8_ETC2 for skybox textures #522

Open
svillar opened this issue Mar 6, 2023 · 7 comments
Open

[PicoXR] Use GL_COMPRESSED_RGB8_ETC2 for skybox textures #522

svillar opened this issue Mar 6, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@svillar
Copy link
Member

svillar commented Mar 6, 2023

PicoOS 5.4 brings support for GL_COMPRESSED_RGB8_ETC2. We can get rid of the code using PNG textures and use the compressed format as we do for the other platforms.

@svillar svillar added the enhancement New feature or request label Mar 6, 2023
@svillar
Copy link
Member Author

svillar commented Mar 6, 2023

Related to this, giving all the issues in <5.4 versions, we should consider dropping support for those versions since those issues affect core parts of the application, I don't think it makes sense for example to distribute both textures in future releases just in case users don't want to upgrade to 5.4 or later.

@CoreaKorea
Copy link

Hello, I'm a Pico 4 user.

When can I use Wolvic?

Or is there another way?

It's so frustrating that it hasn't worked since the 5.4.0 update.

@svillar
Copy link
Member Author

svillar commented Mar 7, 2023

Hello, I'm a Pico 4 user.

When can I use Wolvic?

Or is there another way?

It's so frustrating that it hasn't worked since the 5.4.0 update.

We'll release 1.3.2 addressing the issues in Pico 5.4 really soon. We're sorry for the inconveniences but it was not Wolvic's fault really, but the update that broke previous behaviour of the system without prior notice.

@user080975
Copy link

Is there an approximate date when the new fix might be released for Pico?

@svillar
Copy link
Member Author

svillar commented Mar 13, 2023

Is there an approximate date when the new fix might be released for Pico?

I've just released it 😄

@user080975
Copy link

Thank you! Is there a way to check console or debug my site in Wolvic browser from desktop or someway?

@svillar
Copy link
Member Author

svillar commented Mar 15, 2023

Thank you! Is there a way to check console or debug my site in Wolvic browser from desktop or someway?

Yes, Wolvic supports remote debugging.

That said, please leave this issue for the actual problem described in the first comment, let's not hijack it. Thanks!

felipeerias added a commit that referenced this issue Mar 29, 2023
Pico devices use PNG files to paint their skybox.

This PR adds a filter to exclude unsupported textures (KTX format)
from Pico packages.

Unfortunately, "ignoreAssetsPattern" (Gradle) only supports a basic syntax
so we have to list each individual file name.

This is a partial fix for issue #522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants