-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude unsupported textures from Pico packages #586
base: main
Are you sure you want to change the base?
Conversation
Pico devices use PNG files to paint their skybox. This PR adds a filter to exclude unsupported textures (KTX format) from Pico packages. Unfortunately, "ignoreAssetsPattern" (Gradle) only supports a basic syntax so we have to list each individual file name. This is a partial fix for issue #522.
This PR removes the need for #537 |
I don't think we want to follow this path. We should ideally only use KTX textures. We added the PNG ones as fallback and I'd very much prefer to keep that status. I know you invested a lot trying to make them work, but perhaps the issue is that the non-SRGB versions were incorrectly generated. I remember that I had a lot of issues creating them with the proper size, IIRC I could not even use the compression tool that we have in the sources and had to use another external tool. Perhaps that's the way to go. |
@svillar It seems that the textures for the "cyberpunk" environment are different from the earlier ones for the "wolvic" environment.
So this is something that we should fix. Nevertheless, there might be something else going on because the older textures also use the wrong colors. Both the sRGB textures (
However, what is really weird is that the screenshot with sRGB textures looks correct 😨
|
Yeah, I understand they're different because I used different tools to generate them from the PNGs. The older ones used a tool which is in the sources, but that didn't work when generating the ones for cyberpunk so I had to use an alternate solution (don't remember which one right now) |
Pico devices use PNG files to paint their skybox.
This PR adds a filter to exclude unsupported textures (KTX format) from Pico packages.
Unfortunately, "ignoreAssetsPattern" (Gradle) only supports a basic syntax so we have to list each individual file name.
This is a partial fix for issue #522.