New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Gecko builds are not used by default when building a package #890
Labels
bug
Something isn't working
Comments
FYI, here's our previous discussion. |
felipeerias
added a commit
that referenced
this issue
Aug 4, 2023
We need to use the "nightly" Gecko module so it can be replaced by the script substitute-local-geckoview.gradle See #890
felipeerias
added a commit
that referenced
this issue
Aug 4, 2023
We need to use the "nightly" Gecko module so it can be replaced by the script substitute-local-geckoview.gradle See #890
felipeerias
added a commit
that referenced
this issue
Aug 4, 2023
We need to use the "nightly" Gecko module so it can be replaced by the script substitute-local-geckoview.gradle See #890
felipeerias
added a commit
that referenced
this issue
Aug 4, 2023
We need to use the "nightly" Gecko module so it can be replaced by the script substitute-local-geckoview.gradle See #890
felipeerias
added a commit
that referenced
this issue
Aug 4, 2023
We need to use the "nightly" Gecko module so it can be replaced by the script substitute-local-geckoview.gradle See #890
svillar
pushed a commit
that referenced
this issue
Aug 4, 2023
We need to use the "nightly" Gecko module so it can be replaced by the script substitute-local-geckoview.gradle See #890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In our current build configuration, the local Gecko build is not actually used when building a package.
Here is a detailed explanation:
The group of dependencies under
org.mozilla.geckoview
contains several modules, which we define in the fileversions.gradle
.For example, for ARM64 there is a "nightly" module
geckoview-nightly-arm64-v8a
and a "release" modulegeckoview-arm64-v8a
.In the project's
build.gradle
, we select one of those variants. At the moment, by default we use the "release" modulegeckoview-arm64-v8a
:However, we also support local Gecko builds. In order to do that, we call a script provided by Gecko:
substitute-local-geckoview.gradle
This script replaces dependencies to Gecko modules with the local Gecko build. Unexpectedly, it will only replace modules that are of the "nightly" or "beta" types:
The script will not substitute a "release" module.
The simplest workaround for this problem is to use
def branch = "nightly"
, but we should look for a better solution.The text was updated successfully, but these errors were encountered: