Support using maven GV from the release channel #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We supported it at some point but it was broken for some time and we eventually removed it. Now we can restore it. Release versions of Wolvic must not use maven GeckoView versions because they don't include our updates to the Wolvic-Gecko communication protocol, meaning that WebXR won't work. However we can still use it for super-quick bisects for example, or to test 2D browser features in advance without having to build Gecko.
HollowMan6
requested changes
Jul 31, 2023
Co-authored-by: Hollow Man <hollowman@opensuse.org>
|
Updated build instructions since we are now using the release channel and local GeckoView won't get substituted with that. https://github.com/Igalia/wolvic/wiki/Developer-workflow:-building-steps/_compare/7b87d900bcc71ef9697b4e1593eee7eabf4a3378...3aa0fe4b14437ac0eff1021e07f9f3109a45343b |
Hmm that's a really good point. I wonder whether it actually makes sense to enable the release channel because not getting the substitution because of that seems a potential source of big issues... I'm thinking about reverting |
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We supported it at some point but it was broken for some time and we eventually removed it. Now we can restore it. Release versions of Wolvic must not use maven GeckoView versions because they don't include our updates to the Wolvic-Gecko communication protocol, meaning that WebXR won't work. However we can still use it for super-quick bisects for example, or to test 2D browser features in advance without having to build Gecko. Co-authored-by: Hollow Man <hollowman@opensuse.org>
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We supported it at some point but it was broken for some time and we eventually removed it. Now we can restore it. Release versions of Wolvic must not use maven GeckoView versions because they don't include our updates to the Wolvic-Gecko communication protocol, meaning that WebXR won't work. However we can still use it for super-quick bisects for example, or to test 2D browser features in advance without having to build Gecko. Co-authored-by: Hollow Man <hollowman@opensuse.org>
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We supported it at some point but it was broken for some time and we eventually removed it. Now we can restore it. Release versions of Wolvic must not use maven GeckoView versions because they don't include our updates to the Wolvic-Gecko communication protocol, meaning that WebXR won't work. However we can still use it for super-quick bisects for example, or to test 2D browser features in advance without having to build Gecko. Co-authored-by: Hollow Man <hollowman@opensuse.org>
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We supported it at some point but it was broken for some time and we eventually removed it. Now we can restore it. Release versions of Wolvic must not use maven GeckoView versions because they don't include our updates to the Wolvic-Gecko communication protocol, meaning that WebXR won't work. However we can still use it for super-quick bisects for example, or to test 2D browser features in advance without having to build Gecko. Co-authored-by: Hollow Man <hollowman@opensuse.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We supported it at some point but it was broken for some time and we
eventually removed it. Now we can restore it. Release versions of Wolvic
must not use maven GeckoView versions because they don't include our
updates to the Wolvic-Gecko communication protocol, meaning that
for example WebXR won't work.
However we can still use it for super-quick bisects for example, or to test
2D browser features in advance without having to build Gecko.