Generalize pointer scaling and color change during trigger event #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we are using the `pinchFactor` value to scale the pointer target as a select (trigger) gesture is closing during hand-tracking. But since we are going to extend this to controllers' trigger button, we are renaming it to `selectFactor` to make it generic to a select event.
This patch extends the feature we currently have for pinch gesture, where the pointer target is scaled as the pinch gesture closes, until it is fully closed and the color is changed to blue. With this, we provide a nice visual cue of the trigger event to the user, and also make Wolvic interactions more consistent.
It was (arguably) a bit too big already, and now that we are using it for controllers too, it makes sense to reduce it a bit.
elima
requested review from
felipeerias,
svillar,
javifernandez and
HollowMan6
felipeerias
pushed a commit
that referenced
this pull request
Oct 20, 2023
* Renames Controller::pinchFactor to Controller::selectFactor Right now we are using the `pinchFactor` value to scale the pointer target as a select (trigger) gesture is closing during hand-tracking. But since we are going to extend this to controllers' trigger button, we are renaming it to `selectFactor` to make it generic to a select event. * Scale down and change color of pointer target during select event This patch extends the feature we currently have for pinch gesture, where the pointer target is scaled as the pinch gesture closes, until it is fully closed and the color is changed to blue. With this, we provide a nice visual cue of the trigger event to the user, and also make Wolvic interactions more consistent. * Reduce pointer target maximum size a bit It was (arguably) a bit too big already, and now that we are using it for controllers too, it makes sense to reduce it a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series extends to controllers the feature we currently have for pinch gesture, where the pointer target is scaled as the pinch gesture closes, until it is fully closed and the color is changed to blue.
With this, we provide a nice visual cue of the trigger event to the user when using the controllers, and also make Wolvic interactions more consistent.
As part of this change, we rename
Controller::pinchFactortoController::selectFactoraccordingly, since it is now used beyond pinch.Also, we propose reducing the maximum pointer radius a bit, which was (arguably) a bit too big already for hand-tracking.