Implement Find in Page

[HollowMan6]

Resolve #929

Translations are copied from Chromium. https://github.com/chromium/chromium/blob/main/components/strings/components_strings_en-GB.xtb

translation id: 3495081129428749620

[svillar]

This is excellent!

There is some more work to be done though so that we could eventually use it also with the Chromium backend though. We cannot break the engine agnostic approach of wolvic's architecture.

[javifernandez]

Awesome !

[svillar]

Looking great, just some minor comments

[svillar]

BTW I forgot to mention, please add some placeholders or empty implementations for the chromium backend, otherwise this patch would break the chromium build

[svillar]

Another comment, this is kind of a request that you could ignore if it involves a lot of work. I thought it'd be nice to show the prev/next buttons as inactive/hidden whenever either there is no result or there is no text to search yet. I guess this can be done in the xml by adding a condition on the number of results...

[HollowMan6]

BTW I forgot to mention, please add some placeholders or empty implementations for the chromium backend, otherwise this patch would break the chromium build

Add the getSessionFinder method override in chromium SessionImpl, hopefully, that will make the chromium backend build. But I don't have a test environment for that so I'm not 100% sure.

Another comment, this is kind of a request that you could ignore if it involves a lot of work. I thought it'd be nice to show the prev/next buttons as inactive/hidden whenever either there is no result or there is no text to search yet. I guess this can be done in the xml by adding a condition on the number of results...

This should be done on the Mozilla Android component side (UI-related), maybe we can open an issue for feature requests there. https://github.com/mozilla-mobile/firefox-android/tree/main/android-components/components/feature/findinpage

[HollowMan6]

Another comment, this is kind of a request that you could ignore if it involves a lot of work. I thought it'd be nice to show the prev/next buttons as inactive/hidden whenever either there is no result or there is no text to search yet. I guess this can be done in the xml by adding a condition on the number of results...

This should be done on the Mozilla Android component side (UI-related), maybe we can open an issue for feature requests there. https://github.com/mozilla-mobile/firefox-android/tree/main/android-components/components/feature/findinpage

Submitted a feature request at: https://connect.mozilla.org/t5/ideas/find-in-page-for-firefox-android-hide-inactivate-previous-amp/idi-p/38778