Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative use case/success story resolution #198

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Alternative use case/success story resolution #198

merged 5 commits into from
Nov 20, 2023

Conversation

bkardell
Copy link
Member

@bkardell bkardell commented Nov 15, 2023

We've had an open problem for some time that we'd like to highlight more in the main page, and the suggestion was to add a carousel with success stories or use cases. For whatever reason we currently have 2 issues: First, we only have 2 approved entries. Carousels are already usually not a great choice for a bunch of reasons, but a carousel with only 2 things in it just seems weird, to be honest. The other issue is that carousels should really contain "like" things and these are not - one is a use case and the other is a success story. So, there's been a PR for some time at #168 but it isn't deploying and also makes a specific choice there.

I just wanted to offer a very very simple alternative: Let's literally just put two things in that section until we get at least a third?


Site preview: https://igalia.github.io/wpewebkit.org/carousel/

@bkardell bkardell marked this pull request as draft November 15, 2023 17:44
@mariospr
Copy link
Member

@bkardell The preview does not work, would you mind attaching a screenshot so that we can see how it looks?

@bkardell
Copy link
Member Author

It would look basically like this. Keep it simple:

Screenshot 2023-11-16 at 10 17 41 AM

@meyerweb
Copy link
Member

I tweaked Brian’s work to balance things a bit more, and for better behavior across breakpoints. Here’s a preview:

CleanShot 2023-11-16 at 13 09 20

Absent objections, I’ll deploy this some time on Friday, November 17th.

@mariospr
Copy link
Member

@bkardell @meyerweb Thanks for the screenshots!

It looks good to me, but if I can add a suggestion, I'd rather reverse the order and put Metrological first, since I think it's the most relevant item in the list IMHO.

@meyerweb meyerweb marked this pull request as ready for review November 20, 2023 17:15
@meyerweb meyerweb merged commit 425af91 into master Nov 20, 2023
1 check passed
@meyerweb meyerweb deleted the carousel branch November 20, 2023 18:33
@mariospr
Copy link
Member

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants