Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon-button): font awesome icons not centered #10844

Merged
merged 2 commits into from
Jan 24, 2022
Merged

fix(icon-button): font awesome icons not centered #10844

merged 2 commits into from
Jan 24, 2022

Conversation

SisIvanova
Copy link
Collaborator

Closes #10740

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova added 🐛 bug Any issue that describes a bug 🖼️ icon ❌ status: awaiting-test PRs awaiting manual verification version: 13.0.x labels Jan 17, 2022
@SisIvanova SisIvanova linked an issue Jan 17, 2022 that may be closed by this pull request
igx-icon of the Font Awesome family within an Icon Button is not centered correctly #10740
Closed
@ddaribo ddaribo added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 19, 2022
@simeonoff simeonoff merged commit 646578d into 13.0.x Jan 24, 2022
@simeonoff simeonoff deleted the SIvanova/icon-button-issue-13.0.x branch January 24, 2022 12:24
@renovate renovate bot mentioned this pull request Jan 25, 2022
Merged
1 task
This was referenced Feb 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@ddaribo ddaribo

Labels
🐛 bug Any issue that describes a bug 🖼️ icon version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

igx-icon of the Font Awesome family within an Icon Button is not centered correctly
3 participants
@SisIvanova @simeonoff @ddaribo