Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(splitter): Set min/maxSize inputs to the min/max width/height dep… #11756

Merged
merged 5 commits into from
Jun 27, 2022
Merged

fix(splitter): Set min/maxSize inputs to the min/max width/height dep… #11756

merged 5 commits into from
Jun 27, 2022

Conversation

mddragnev
Copy link
Member

…ending on the type of the splitter

Closes #11611

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@tishko0 tishko0 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 22, 2022
ChronosSF
ChronosSF previously approved these changes Jun 24, 2022
View reviewed changes
MayaKirova
MayaKirova reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@MayaKirova MayaKirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one of the commits is missing from this PR: 85f1588

@dkamburov
Copy link
Contributor

I've cherry-picked it

MayaKirova
MayaKirova previously approved these changes Jun 27, 2022
View reviewed changes
@dkamburov dkamburov added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jun 27, 2022
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 27, 2022
@dkamburov dkamburov merged commit e38930d into 12.3.x Jun 27, 2022
@dkamburov dkamburov deleted the mdragnev/fix-11611-12.3.x branch June 27, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

@ChronosSF ChronosSF ChronosSF left review comments

@skrustev skrustev Awaiting requested review from skrustev

Assignees

@dkamburov dkamburov

@tishko0 tishko0

Labels
splitter version: 12.3.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mddragnev @dkamburov @ChronosSF @MayaKirova @tishko0 @kdinev