Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combo): selectable unique falsy values #11610 #11859

Merged
merged 11 commits into from
Jul 20, 2022
Merged

fix(combo): selectable unique falsy values #11610 #11859

merged 11 commits into from
Jul 20, 2022

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Jul 14, 2022

Closes #11610
Related #10952

** NOTE FOR TESTING **: Please verify that the scenario in this conversation is also covered by the fix!

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@wnvko
Copy link
Contributor

wnvko commented Jul 15, 2022

should we make this work and with array of primitive values, e.g. combo.data = [ null, false, true, '', 0, undefined]?

@kdinev
Copy link
Member Author

kdinev commented Jul 15, 2022

@wnvko I would say not really. Those values don't have meaningful display representation to the end-user, so I don't consider this to be a real scenario that we should support.

wnvko
wnvko previously approved these changes Jul 15, 2022
@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 15, 2022
@RivaIvanova RivaIvanova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 18, 2022
@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 18, 2022
@Lipata Lipata merged commit c407417 into 14.0.x Jul 20, 2022
@Lipata Lipata deleted the combo-11610 branch July 20, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
combo simple-combo version: 14.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants