Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error emitting when IgxDatePicker value property is initialized with empty string. #3021

Closed
HristoP96 opened this issue Nov 14, 2018 · 0 comments
Closed

Error emitting when IgxDatePicker value property is initialized with empty string. #3021

HristoP96 opened this issue Nov 14, 2018 · 0 comments
Assignees
@zdrawku @HristoP96
Labels
🐛 bug Any issue that describes a bug 📅 date-picker ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@HristoP96
Copy link

Description

The IgxDatePicker allows the value property to call getHours/getMinutes/getSeconds/getMilliseconds when it is initialized with an empty string.

Steps to reproduce

Bind the value property of IgxDatePicker with an empty string and click on the IgxDatePicker to set Date

Result

When you click on the Calendar an error is thrown -this.value.getHours is not a function and the Date is not set.

Expected result

The Date should be set.

Attachments

errorcausing

datepickererror
@hanastasov hanastasov assigned HristoP96 and unassigned hanastasov Nov 14, 2018
@HristoP96 HristoP96 added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 19, 2018
HristoP96 pushed a commit that referenced this issue Nov 19, 2018
fix(date-picker): Prevenitng redundant method calls on value. #3021
083ead4
@HristoP96 HristoP96 mentioned this issue Nov 19, 2018
Merged
HristoP96 pushed a commit that referenced this issue Nov 19, 2018
fix(date-picker): Prevenitng redundant method calls on value. #3021
515214e
@HristoP96 HristoP96 mentioned this issue Nov 19, 2018
Merged
@HristoP96 HristoP96 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 19, 2018
HristoP96 pushed a commit that referenced this issue Nov 21, 2018
fix(date-picker): Changing the check for value property on selection. #…
64f0590 
…3021
HristoP96 pushed a commit that referenced this issue Nov 21, 2018
fix(date-picker): Changing the check for value property on selection. #…
9ee803f 
…3021
kdinev pushed a commit that referenced this issue Nov 22, 2018
@kdinev
Prevenitng redundant method calls on value property when initialized …
74fc3cc 
…with an empty string(master) (#3042)

* fix(date-picker): Prevenitng redundant method calls on value. #3021

* fix(date-picker): Changing the check for value property on selection. #3021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdrawku zdrawku

@HristoP96 HristoP96

Labels
🐛 bug Any issue that describes a bug 📅 date-picker ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zdrawku @hanastasov @HristoP96