Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a shadow, when autocomplete list is empty #3977

Closed
Lipata opened this issue Feb 22, 2019 · 2 comments · Fixed by #4076, #7628, #7745, #7961 or #8032
Closed

There is a shadow, when autocomplete list is empty #3977

Lipata opened this issue Feb 22, 2019 · 2 comments · Fixed by #4076, #7628, #7745, #7961 or #8032
Assignees
@Lipata @ViktorSlavov
Labels
autocomplete 🐛 bug Any issue that describes a bug dropdown severity: low version: 9.1.x version: 10.0.x version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
19.1 Sprint 29 15-June-20 M12 Sprint 1 10-Aug-20 M13 Sprint 1

Comments

@Lipata
Copy link
Member

Lipata commented Feb 22, 2019

Description

When autocomplete is filtered so that there are no items left, there is still a shadow.

Attachments

image
@Lipata Lipata self-assigned this Feb 22, 2019
damyanpetev added a commit that referenced this issue Feb 27, 2019
@damyanpetev
fix(dropdown): remove box shadow when the list is empty #3977
f5f58e9
@damyanpetev damyanpetev mentioned this issue Feb 27, 2019
Merged
14 tasks
@damyanpetev damyanpetev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Feb 27, 2019
@Lipata Lipata added this to To do in 19.1 Sprint 29 via automation Feb 27, 2019
@zdrawku zdrawku moved this from To do to In progress in 19.1 Sprint 29 Feb 27, 2019
19.1 Sprint 29 automation moved this from In progress to Done Feb 28, 2019
kdinev added a commit that referenced this issue Feb 28, 2019
@kdinev
Merge pull request #4076 from IgniteUI/dpetev/empty-dd-shadow
0a9cff1 
fix(dropdown): remove box shadow when the list is empty #3977
@Lipata Lipata reopened this Jun 18, 2020
@Lipata
Copy link
Member Author

Lipata commented Jun 18, 2020

After the introduction of the internal scroll container, the issue is again reproducible.

@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Jun 18, 2020
Lipata added a commit that referenced this issue Jun 18, 2020
@Lipata
fix(drop-down): remove shadow when list is empty #3977
06d887e
Lipata added a commit that referenced this issue Jun 18, 2020
@Lipata
fix(drop-down): remove shadow when list is empty #3977
ef83e3d
Lipata added a commit that referenced this issue Jun 18, 2020
@Lipata
fix(drop-down): remove shadow when list is empty #3977
e61d4b4
This was referenced Jun 18, 2020
Merged
Merged
Merged
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 18, 2020
@radomirchev radomirchev added this to Validation in 15-June-20 M12 Sprint 1 Jun 18, 2020
Lipata added a commit that referenced this issue Jul 6, 2020
@Lipata
refactor(drop-down, autocomplete): apply comments #3977
1a70154
@ViktorSlavov ViktorSlavov added version: 9.1.x 🛠️ status: in-development Issues and PRs with active development on them version: 10.1.x and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. version: 7.2.x version: 9.0.x labels Aug 10, 2020
ViktorSlavov added a commit that referenced this issue Aug 11, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
1a11e84
ViktorSlavov added a commit that referenced this issue Aug 11, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
b515e3c
ViktorSlavov added a commit that referenced this issue Aug 11, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
78e5936
This was referenced Aug 11, 2020
Merged
Merged
Merged
@ViktorSlavov ViktorSlavov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 13, 2020
ViktorSlavov added a commit that referenced this issue Aug 13, 2020
@ViktorSlavov
fix(autocomplete): do not try to open dropdown if it's empty, #3977
40c28e3
ViktorSlavov added a commit that referenced this issue Aug 13, 2020
@ViktorSlavov
fix(autocomplete): do not try to open dropdown if it's empty, #3977
93e2892
ViktorSlavov added a commit that referenced this issue Aug 13, 2020
@ViktorSlavov
fix(autocomplete): do not try to open dropdown if it's empty, #3977
f1881f2
ViktorSlavov added a commit that referenced this issue Aug 18, 2020
@ViktorSlavov
test(autocomplete): fix failing tests, #3977
82cb9ec
ViktorSlavov added a commit that referenced this issue Aug 21, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
0d6819d
ViktorSlavov added a commit that referenced this issue Aug 21, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
761c864
ViktorSlavov added a commit that referenced this issue Aug 21, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
8f79d94
ViktorSlavov added a commit that referenced this issue Aug 21, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
000c26a
@ViktorSlavov ViktorSlavov mentioned this issue Aug 21, 2020
Merged
14 tasks
ViktorSlavov added a commit that referenced this issue Aug 21, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977
a24c371
@radomirchev radomirchev added this to Validation in 10-Aug-20 M13 Sprint 1 Aug 21, 2020
damyanpetev pushed a commit that referenced this issue Aug 26, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977 - 9.1.x (#…
015df50 
…7962)
damyanpetev pushed a commit that referenced this issue Aug 26, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977 (#7963)
d58a086
damyanpetev pushed a commit that referenced this issue Aug 26, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977 (#7961)
1534623
damyanpetev pushed a commit that referenced this issue Aug 26, 2020
@ViktorSlavov
fix(autocomplete): close dropdown when list is empty, #3977 (#8032)
de97dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@ViktorSlavov ViktorSlavov

Labels
autocomplete 🐛 bug Any issue that describes a bug dropdown severity: low version: 9.1.x version: 10.0.x version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
No open projects
10-Aug-20 M13 Sprint 1
  
Validation
15-June-20 M12 Sprint 1
  
Validation
19.1 Sprint 29
  
Done
Milestone
No milestone
3 participants
@Lipata @damyanpetev @ViktorSlavov