Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding a group row while at the bottom of the grid throws error #4179

Closed
skrustev opened this issue Mar 5, 2019 · 0 comments · Fixed by #4180
Closed

Expanding a group row while at the bottom of the grid throws error #4179

skrustev opened this issue Mar 5, 2019 · 0 comments · Fixed by #4180
Assignees
@skrustev @mpavlinov
Labels
🐛 bug Any issue that describes a bug 🔥 severity: high grid: groupby triage: blocking version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
19.1 Sprint 29

Comments

@skrustev
Copy link
Member

skrustev commented Mar 5, 2019 •
edited

Description

Error is thrown when having two collapsed group rows at the bottom and we try to expand the upper one.

  • igniteui-angular version: 7.2.x
  • browser: All

Steps to reproduce

  1. Run the Grid Search sample.
  2. Group by Contact Title column.
  3. Scroll to the bottom of the grid using mouse wheel.
  4. Collapse Sales Representative group.
  5. Collapse Sales Manager group.
  6. Expand the Sales Manager group.

Note: There are other scenarios that this is reproduced by also expanding while having collapsed groups, but this seems to be the one of the more consistent scenarios.

Result

The following error is thrown:
ERROR TypeError: Cannot read property 'forEach' of undefined

Expected result

There should be no error thrown.
@skrustev skrustev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 5, 2019
skrustev added a commit that referenced this issue Mar 5, 2019
@skrustev
fix(GroupBy): Fix error thrown when expanding a groupby row. #4179
332ab77
@skrustev skrustev mentioned this issue Mar 5, 2019
Merged
14 tasks
@skrustev skrustev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 5, 2019
@mpavlinov mpavlinov added this to To do in 19.1 Sprint 29 via automation Mar 6, 2019
@mpavlinov mpavlinov moved this from To do to In progress in 19.1 Sprint 29 Mar 6, 2019
skrustev added a commit that referenced this issue Mar 6, 2019
@skrustev
fix(GroupBy): Fix error thrown when expanding a groupby row other way. …
75b127f 
…#4179
skrustev added a commit that referenced this issue Mar 6, 2019
@skrustev
fix(GroupBy): Small code reorganizing for cachedViewLoaded method. #4179
4e7c336
19.1 Sprint 29 automation moved this from In progress to Done Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skrustev skrustev

@mpavlinov mpavlinov

Labels
🐛 bug Any issue that describes a bug 🔥 severity: high grid: groupby triage: blocking version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
No open projects
19.1 Sprint 29
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(GroupBy): Fix error thrown when expanding a groupby row. IgniteUI/igniteui-angular
2 participants
@skrustev @mpavlinov