Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel Style Filtering Overlay not fully shown on limited space #5773

Closed
RolandTa opened this issue Sep 11, 2019 · 3 comments · Fixed by #5885
Closed

Excel Style Filtering Overlay not fully shown on limited space #5773

RolandTa opened this issue Sep 11, 2019 · 3 comments · Fixed by #5885
Assignees
Labels
🐛 bug Any issue that describes a bug grid: excel-style-filtering grid: general version: 8.1.4 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@RolandTa
Copy link

Description

When only limited space is available the excel style filtering overlay is not fully shown.

  • igniteui-angular version: 8.1.4
  • browser: Google Chrome 76.0.3809.132

Steps to reproduce

See https://stackblitz.com/edit/angular-qdpv3z and open the filter overlay.

Result

The overlay is not fully shown and will be cut.
image

Expected result

The overlay settings should be adjusted to AutoPositionStrategy or there should be an option to custom define the overlay setting.

@zdrawku
Copy link
Contributor

zdrawku commented Sep 12, 2019

@RolandTa, actually this is not a bug in the ExcelStyleFiltering component. Currently, the position strategy that is used (ConnectedPositioningStrategy) is expected to be working that way. What can we do:

  • we can change the default Connected strategy to one of the following - AutoPositionStrategy or ElasticPositionStrategy. This will introduce some changes in the visual behavior, although it will prevent the scenario that you've pointed out - behaviors like, positioning of the overlay over the open-filter button or moving it over another element in the page (gif provided below)
  • expose @input for positionStrategy.
  • as @DiyanDimitrov and @radomirchev already discussed, we can provide a way to visualize the ExcelStyleFilter dialog in certain custom panel or other containers.

elastic

Note: there is a fixed height to the grid-excel-filter element that should be removed in _excel-filtering-theme.scss

@mixin _excel-filtering($theme, $palette) {
    %grid-excel-filter {
        // height: rem(15px);
        display: block;
    }

@StefanIvanov @DaniMarinov you can provide comments on the visual behavior change that may happen

@DaniMarinov
Copy link

@RolandTa Definitely, the best solution is what @zdrawku suggested - AutoPositionStrategy or ElasticPositionStrategy. Of course, if you want to further optimize it , you can switch off Pinning and Sorting within the Excel Style Filtering, as well as to enlarge the height of the grid.

@RolandTa
Copy link
Author

@DaniMarinov @zdrawku Thanks for your suggestions which sounds good to me. Changing the default behavior to AutoPositionStrategy or EleasticPositionStrategy would solve my issue. In case this would somehow break current design behavior - exposing an @input to define the positionStrategy by myself would also do the trick.

@zdrawku zdrawku self-assigned this Sep 25, 2019
@zdrawku zdrawku added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Sep 26, 2019
@zdrawku zdrawku added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 27, 2019
@radomirchev radomirchev added this to Validation in 19M9 Sprint 6 Sep 30, 2019
DiyanDimitrov added a commit that referenced this issue Sep 30, 2019
fix(grid): Start using AutoPositionStrategy #5773
@radomirchev radomirchev moved this from Validation to Done in 19M9 Sprint 6 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug grid: excel-style-filtering grid: general version: 8.1.4 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
No open projects
19M9 Sprint 6
  
Done
Development

Successfully merging a pull request may close this issue.

7 participants