Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating a number column with value 0 does not mark the row as updated #5855

Closed
hanastasov opened this issue Sep 25, 2019 · 0 comments · Fixed by #5885
Closed

Updating a number column with value 0 does not mark the row as updated #5855

hanastasov opened this issue Sep 25, 2019 · 0 comments · Fixed by #5885
Assignees
@Lipata @PlamenaMiteva
Labels
batch-editing 🐛 bug Any issue that describes a bug grid: general severity: low version: 8.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@hanastasov
Copy link
Contributor

Description

Cell is not styled as batch updated, when upated with a value of 0.

  • igniteui-angular version: 8.2.0-beta.6

Steps to reproduce

  1. Go to https://stackblitz.com/edit/angular-ftoheg
  2. Update a cell in the Unit Price column with a value of 0

Result

Cell is not styled as batch updated.

Expected result

Cell to be styled as batch updated.

Attachments

Attach a sample if available, and screenshots, if applicable.
@hanastasov hanastasov added 🐛 bug Any issue that describes a bug grid: general batch-editing labels Sep 25, 2019
@PlamenaMiteva PlamenaMiteva added the 🛠️ status: in-development Issues and PRs with active development on them label Oct 1, 2019
PlamenaMiteva added a commit that referenced this issue Oct 1, 2019
@PlamenaMiteva
fix(grid): update row transaction value check #5855
262b836
@PlamenaMiteva PlamenaMiteva mentioned this issue Oct 1, 2019
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Oct 2, 2019
@PlamenaMiteva
fix(grid): fix lint error #5855
c9b8b56
PlamenaMiteva added a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva
test(grid): add test for cell editing with values equal to zero or fa…
2a0f443 
…lse #5855
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 4, 2019
Lipata pushed a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva @Lipata
fix(grid): update row transaction value check #5855
da557ed
@zdrawku zdrawku mentioned this issue Oct 4, 2019
Merged
PlamenaMiteva added a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva
fix(grid): update row transaction value check #5855
c85c0cd
PlamenaMiteva added a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva
fix(grid): fix lint error #5855
6e067cf
PlamenaMiteva added a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva
test(grid): add test for cell editing with values equal to zero or fa…
c90ef25 
…lse #5855

# Conflicts:
#	projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts
PlamenaMiteva added a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva
fix(grid): update row transaction value check #5855
bf20cad
PlamenaMiteva added a commit that referenced this issue Oct 4, 2019
@PlamenaMiteva
fix(grid): fix lint error #5855
c35759a
PlamenaMiteva added a commit that referenced this issue Oct 7, 2019
@PlamenaMiteva
test(grid): test cell editing with zero value #5855
5343c6f
@PlamenaMiteva PlamenaMiteva mentioned this issue Oct 7, 2019
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Oct 7, 2019
@PlamenaMiteva
test(grid): test cell editing with zero value #5855
94f2d72
Lipata pushed a commit that referenced this issue Oct 7, 2019
@PlamenaMiteva @Lipata
* fix(grid): update row transaction value check #5855
a4d960c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@PlamenaMiteva PlamenaMiteva

Labels
batch-editing 🐛 bug Any issue that describes a bug grid: general severity: low version: 8.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging 8.2.x into master IgniteUI/igniteui-angular
3 participants
@Lipata @PlamenaMiteva @hanastasov