Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabled igx-datePicker control functionality not working for 'dropdown' mode #7577

Closed
SC003 opened this issue Jun 12, 2020 · 3 comments · Fixed by #7634
Closed

disabled igx-datePicker control functionality not working for 'dropdown' mode #7577

SC003 opened this issue Jun 12, 2020 · 3 comments · Fixed by #7634
Assignees
@Lipata @PlamenaMiteva
Labels
🐛 bug Any issue that describes a bug 📅 date-picker 🧨 severity: medium version: 9.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
15-June-20 M12 Sprint 1

Comments

@SC003
Copy link

SC003 commented Jun 12, 2020

Description

On setting [disabled] = "true" only input part gets disable. User is able to click calender icon for selecting date and also cancel button will clear the selected date

  • igniteui-angular version: 9.1.0
  • browser: chrome

Steps to reproduce

Check below url with setting property [disabled]="true" for editable dropdown
https://stackblitz.com/angular/yryklkvbxgv?file=src%2Fapp%2Fdatepicker-sample-3%2Fdatepicker-sample-3.component.html

Result

only input part gets disabled. user is able to click on date/cancel icon and change/clear the date.

Expected result

date and cancel button icon should be disabled.

Attachments

datepicker-disabled property not working.zip
@SC003 SC003 added the 🐛 bug Any issue that describes a bug label Jun 12, 2020
@Lipata Lipata self-assigned this Jun 12, 2020
@SC003
Copy link
Author

SC003 commented Jun 15, 2020 •
edited

This is the high priority production level issue, kindly provide solution asap.

@PlamenaMiteva PlamenaMiteva added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 17, 2020
@radomirchev radomirchev added this to Development in 15-June-20 M12 Sprint 1 Jun 18, 2020
PlamenaMiteva added a commit that referenced this issue Jun 19, 2020
@PlamenaMiteva
fix(date-picker): fix open & clear in disabled state #7577
807c73f
@PlamenaMiteva PlamenaMiteva mentioned this issue Jun 19, 2020
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Jun 19, 2020
@PlamenaMiteva
fix(date-picker): fix open & clear in disabled state #7577
0b8596d
@PlamenaMiteva PlamenaMiteva mentioned this issue Jun 19, 2020
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Jun 19, 2020
@PlamenaMiteva
fix(date-picker): fix open & clear in disabled state #7577
3e11d6b 
# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
PlamenaMiteva added a commit that referenced this issue Jun 19, 2020
@PlamenaMiteva
fix(date-picker): fix open & clear in disabled state #7577
b4c9437
@PlamenaMiteva PlamenaMiteva mentioned this issue Jun 19, 2020
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Jun 19, 2020
@PlamenaMiteva
chore(date-picker): fix check in clear method #7577
c579a16
@PlamenaMiteva PlamenaMiteva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 22, 2020
@SC003
Copy link
Author

SC003 commented Jun 22, 2020

Is this released or not?
what changes should I need to do to get these updated feature.

@Lipata
Copy link
Member

Lipata commented Jun 22, 2020

@SC003 We are testing it and when it is merged, it will be released next week.

@radomirchev radomirchev moved this from Development to Validation in 15-June-20 M12 Sprint 1 Jun 23, 2020
@radomirchev radomirchev moved this from Validation to Done in 15-June-20 M12 Sprint 1 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@PlamenaMiteva PlamenaMiteva

Labels
🐛 bug Any issue that describes a bug 📅 date-picker 🧨 severity: medium version: 9.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
No open projects
15-June-20 M12 Sprint 1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix open & clear in disabled state IgniteUI/igniteui-angular
3 participants
@Lipata @PlamenaMiteva @SC003