Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IxgDatePicker: Deprecation warning about label property even if it's not implemented. #8917

Closed
valadzhov opened this issue Feb 5, 2021 · 0 comments · Fixed by #8934
Closed

IxgDatePicker: Deprecation warning about label property even if it's not implemented. #8917

valadzhov opened this issue Feb 5, 2021 · 0 comments · Fixed by #8934
Assignees
@valadzhov
Labels
🐛 bug Any issue that describes a bug 📅 date-picker label 🆕 status: new version: 10.2.x version: 11.0.x version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@valadzhov
Copy link
Collaborator

Description

There's a deprecation warning about the label property which is displayed in the console even if the property is not used.

  • igniteui-angular version: 11.1, 11.0, 10.2
  • browser:

Steps to reproduce

  1. Set a label to the date picker as described in the Custom Label section
  2. Start the application

Result

There's a deprecation warning about the label property which suggest to implement a label in the way described in the topic.

Expected result

The deprecation warning shouldn't be displayed if the label property is not used in the application.

Attachments

Sample
@valadzhov valadzhov self-assigned this Feb 5, 2021
valadzhov added a commit that referenced this issue Feb 8, 2021
@valadzhov
fix(date-picker): Depracation warning for the label property. #8917
80fefd2
valadzhov added a commit that referenced this issue Feb 8, 2021
@valadzhov
fix(date-picker): Depracation warning for the label property. #8917
e0d918b
@valadzhov valadzhov mentioned this issue Feb 8, 2021
Merged
14 tasks
valadzhov added a commit that referenced this issue Feb 8, 2021
@valadzhov
fix(date-picker): Depracation warning for the label property. #8917
99c0a87
@valadzhov valadzhov mentioned this issue Feb 8, 2021
Merged
14 tasks
valadzhov added a commit that referenced this issue Feb 8, 2021
@valadzhov
fix(date-picker): Depracation warning for the label property. #8917
72bfc1f
@Lipata Lipata mentioned this issue Feb 9, 2021
Merged
14 tasks
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 10, 2021
valadzhov added a commit that referenced this issue Feb 11, 2021
@valadzhov
fix(date-picker): Addressing the comments #8917
c8e10ab
valadzhov added a commit that referenced this issue Feb 11, 2021
@valadzhov
fix(date-picker): Addressing the comments #8917
124a179
valadzhov added a commit that referenced this issue Feb 11, 2021
@valadzhov
fix(date-picker): Addressing the comments #8917
30ad3af
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Changing the default label's property name #8917
84fb846
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Changing the default label's property name #8917
1c769f8
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Changing the default label's property name #8917
e8bc1e2
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Change the property for the other template #8917
e98f165
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Change the property for the other template #8917
2d9ff54
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Change the property for the other template #8917
fdfc3de
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Removing unnecessary file #8917
ed9beac
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Adding labelInternal #8917
721ccd5
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Removing unnecessary file #8917
f48b3fe
valadzhov added a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): Removing unnecessary file #8917
64ba791
Lipata added a commit that referenced this issue Feb 12, 2021
@Lipata
fix(date-picker): remove deprecation warning for the label property. #…
df0b2ea 
…8917 (#8937)
Lipata pushed a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): remove deprecation warning for the label property. #…
6b2fe5c 
…8917 (#8937)
Lipata pushed a commit that referenced this issue Feb 12, 2021
@valadzhov
fix(date-picker): remove deprecation warning for the label property. #…
45a443b 
…8917 (#8937)
@wnvko wnvko mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valadzhov valadzhov

Labels
🐛 bug Any issue that describes a bug 📅 date-picker label 🆕 status: new version: 10.2.x version: 11.0.x version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(date-picker): Deprecation warning for the label property. #8917 IgniteUI/igniteui-angular
2 participants
@Lipata @valadzhov