Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IgxCombo] onAddition event does not give enough control over added item #9283

Closed
ViktorSlavov opened this issue Apr 7, 2021 · 0 comments · Fixed by #9284
Closed

[IgxCombo] onAddition event does not give enough control over added item #9283

ViktorSlavov opened this issue Apr 7, 2021 · 0 comments · Fixed by #9284
Assignees
@Lipata @ViktorSlavov
Labels
📈 enhancement combo version: 12.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ViktorSlavov
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When adding an item to the combo though the combo's onAddtion event, I would like to have more control over the value added

Describe the solution you'd like

I'd like to be able to cancel the event, so that the item is not added to the combo's data.
I'd like to be able to manipulate the added item, in case I need to standardize some of its properties (e.g. trim label, convert ID)

Describe alternatives you've considered

Overriding the igxAddItemButton and handling the event separately, like in this example
@ViktorSlavov ViktorSlavov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Apr 7, 2021
ViktorSlavov added a commit that referenced this issue Apr 7, 2021
@ViktorSlavov
feat(combo): onAddition event can now be canceled, #9283
12ab098
@ViktorSlavov ViktorSlavov mentioned this issue Apr 7, 2021
Merged
14 tasks
ViktorSlavov added a commit that referenced this issue Apr 7, 2021
@ViktorSlavov
feat(combo): onAddition event can now be canceled, #9283
f0d7439
@ViktorSlavov ViktorSlavov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 8, 2021
Lipata pushed a commit that referenced this issue Apr 9, 2021
@ViktorSlavov
feat(combo): onAddition event can now be canceled #9283 (#9284)
abe68fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@ViktorSlavov ViktorSlavov

Labels
📈 enhancement combo version: 12.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(combo): onAddition event can now be canceled IgniteUI/igniteui-angular
2 participants
@Lipata @ViktorSlavov