Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay wrapper and element animation should start together #10232

Merged
merged 23 commits into from
Oct 11, 2021
Merged

Overlay wrapper and element animation should start together #10232

merged 23 commits into from
Oct 11, 2021

Conversation

PlamenaMiteva
Copy link
Contributor

@PlamenaMiteva PlamenaMiteva commented Oct 4, 2021 •
edited by wnvko
Loading

Closes #9882

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

wnvko
wnvko requested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working for close animation.
Note, I've pushed a change to overlay sample in this PR - you can now set the animation duration in the animation sample.

projects/igniteui-angular/src/lib/services/overlay/overlay.ts Outdated Show resolved Hide resolved
wnvko
wnvko previously approved these changes Oct 4, 2021
View reviewed changes
@wnvko wnvko self-requested a review October 4, 2021 12:40
@Lipata Lipata requested a review from wnvko October 5, 2021 10:47
@wnvko wnvko self-requested a review October 5, 2021 18:48
wnvko
wnvko previously approved these changes Oct 5, 2021
View reviewed changes
@wnvko wnvko added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 6, 2021
@wnvko wnvko added the 🛠️ status: in-development Issues and PRs with active development on them label Oct 6, 2021
@wnvko
Copy link
Contributor

wnvko commented Oct 6, 2021

First time element is shown in the overlay wrapper element's CSS animation does not play. Most probably background color is not applied. Putting addition of igx-overlay__wrapper--modal class in RAF should fix this.

wnvko
wnvko previously approved these changes Oct 8, 2021
View reviewed changes
@wnvko wnvko added ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 8, 2021
@wnvko wnvko removed their assignment Oct 8, 2021
@wnvko wnvko added the squash-merge Merge PR with "Squash and Merge" option label Oct 8, 2021
@Lipata Lipata requested a review from wnvko October 8, 2021 20:35
@Lipata Lipata merged commit 7d069c2 into master Oct 11, 2021
@Lipata Lipata deleted the PMiteva/fix-overlay-animation branch October 11, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

Assignees
No one assigned
Labels
overlay squash-merge Merge PR with "Squash and Merge" option version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlay wrapper animation should start together with overlay element animation
4 participants
@PlamenaMiteva @wnvko @Lipata @kdinev