Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IColumnState): add disableHiding property #10291

Merged
merged 12 commits into from
Oct 18, 2021
Merged

feat(IColumnState): add disableHiding property #10291

merged 12 commits into from
Oct 18, 2021

Conversation

katherinedragieva
Copy link
Contributor

@katherinedragieva katherinedragieva commented Oct 13, 2021 •
edited
Loading

Closes #9304

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@katherinedragieva katherinedragieva added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 13, 2021
@katherinedragieva katherinedragieva linked an issue Oct 13, 2021 that may be closed by this pull request
Is the IgxGridState directive supposed to honor the disableHiding column attribute? #9304
Closed
hanastasov
hanastasov previously approved these changes Oct 13, 2021
View reviewed changes
@Volen99 Volen99 added the ✅ status: verified Applies to PRs that have passed manual verification label Oct 14, 2021
@katherinedragieva katherinedragieva removed the ❌ status: awaiting-test PRs awaiting manual verification label Oct 14, 2021
kdinev
kdinev previously approved these changes Oct 15, 2021
View reviewed changes
@kdinev
Copy link
Member

kdinev commented Oct 18, 2021

@katherinedragieva This fix should also be cherry-picked and PRed against 12.2.x and 11.1.x.

@hanastasov hanastasov self-requested a review October 18, 2021 07:13
hanastasov
hanastasov requested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the disableHiding property in a columns collection used with the setState method.

@hanastasov hanastasov changed the title feat(IColumnState): add disableHiding property [DO NOT MERGE] feat(IColumnState): add disableHiding property Oct 18, 2021
@hanastasov hanastasov changed the title [DO NOT MERGE] feat(IColumnState): add disableHiding property feat(IColumnState): add disableHiding property Oct 18, 2021
@hanastasov hanastasov self-requested a review October 18, 2021 10:54
@kdinev kdinev merged commit d4eed07 into master Oct 18, 2021
@kdinev kdinev deleted the kdragieva/IgxGridState-disableHiding-on-master branch October 18, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov approved these changes

@kdinev kdinev kdinev left review comments

Assignees

@Volen99 Volen99

Labels
grid: column-hiding grid: state-persistence version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is the IgxGridState directive supposed to honor the disableHiding column attribute?
4 participants
@katherinedragieva @kdinev @hanastasov @Volen99