Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): normalize initial value set up #10324

Merged
merged 9 commits into from
Oct 25, 2021
Merged

fix(slider): normalize initial value set up #10324

merged 9 commits into from
Oct 25, 2021

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Oct 20, 2021 •
edited
Loading

Closes #9861

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 20, 2021
@wnvko wnvko self-requested a review October 21, 2021 08:04
wnvko
wnvko previously approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may try add test for this

@Volen99 Volen99 added the ✅ status: verified Applies to PRs that have passed manual verification label Oct 21, 2021
Volen99
Volen99 previously approved these changes Oct 21, 2021
View reviewed changes
@Volen99 Volen99 dismissed stale reviews from wnvko and themself via b05aec7 October 21, 2021 11:28
@Aleksandyr Aleksandyr removed the ❌ status: awaiting-test PRs awaiting manual verification label Oct 21, 2021
@zdrawku zdrawku merged commit 9f6e596 into master Oct 25, 2021
@zdrawku zdrawku deleted the normalize-slider-initialval branch October 25, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@hanastasov hanastasov hanastasov approved these changes

@wnvko wnvko wnvko left review comments

@Volen99 Volen99 Volen99 left review comments

Assignees

@wnvko wnvko

@Volen99 Volen99

Labels
slider version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepped range slider shows incorrect values
6 participants
@Aleksandyr @wnvko @zdrawku @hanastasov @Volen99 @kdinev