Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combo): disable UI click for checkbox in combo #10838 #10850

Merged
merged 2 commits into from Jan 19, 2022
Merged

fix(combo): disable UI click for checkbox in combo #10838 #10850

merged 2 commits into from Jan 19, 2022

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Jan 17, 2022

Closes #10838

Putting the [readonly]=true is needed because of the following change, where _onCheckboxClick is decorated with HostListener for the click: 735619c
Other related PR: e784abf

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Lipata Lipata added ❌ status: awaiting-test PRs awaiting manual verification combo version: 11.1.x labels Jan 17, 2022
@Lipata Lipata changed the title fix(combo): disable UX click for checkbox in combo #10838 fix(combo): disable UI click for checkbox in combo #10838 Jan 17, 2022
wnvko
wnvko previously approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test for the fix please

@Lipata Lipata requested a review from wnvko January 18, 2022 14:43
wnvko
wnvko previously approved these changes Jan 18, 2022
View reviewed changes
@Lipata Lipata force-pushed the nalipiev/combo-checkbox-11.1 branch from b06af65 to b5a78fc Compare January 18, 2022 14:56
@Lipata Lipata requested a review from wnvko January 18, 2022 14:57
wnvko
wnvko previously approved these changes Jan 18, 2022
View reviewed changes
@Lipata Lipata force-pushed the nalipiev/combo-checkbox-11.1 branch from b5a78fc to 650dd62 Compare January 18, 2022 20:34
@Lipata Lipata requested a review from wnvko January 18, 2022 20:34
@valadzhov valadzhov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 19, 2022
@Lipata Lipata merged commit 67f9995 into 11.1.x Jan 19, 2022
@Lipata Lipata deleted the nalipiev/combo-checkbox-11.1 branch January 19, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

@jackofdiamond5 jackofdiamond5 Awaiting requested review from jackofdiamond5

Assignees

@valadzhov valadzhov

Labels
combo version: 11.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lipata @wnvko @valadzhov