-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): Process pinned columns and column groups when the columns … #13844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are dynamically rendered ot the collection is changed
MayaKirova
previously approved these changes
Jan 31, 2024
@mddragnev Not sure if it's the same, if you use the with the following config: <igx-column-group header="Address Information" [(collapsible)]='s' [expanded]='true' [pinned]="true">
<igx-column *ngIf="skip" [filterable]="true" [sortable]="true" [resizable]="true" field="Country" [visibleWhenCollapsed]= 'false' ></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Region" [visibleWhenCollapsed]= 'false'></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="City" [visibleWhenCollapsed]= 'false'></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Address" [visibleWhenCollapsed]= 'false'></igx-column>
<igx-column [filterable]="true" [editable]="true" [sortable]="true" [visibleWhenCollapsed]= 'true' field="FullAddress"></igx-column>
</igx-column-group> |
…g columns. Fix a bug when a child of column group is added dynamically
@mddragnev Ok, the previous comment is resolved, but I think if the ngIf is on the whole group scenario got broken now, I think this was working before the last changes: <igx-column-group header="Address Information" [(collapsible)]='s' [expanded]='true' [pinned]="true" *ngIf="skip">
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Country" [visibleWhenCollapsed]= 'false' ></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Region" [visibleWhenCollapsed]= 'false'></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="City" [visibleWhenCollapsed]= 'false'></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Address" [visibleWhenCollapsed]= 'false'></igx-column>
<igx-column [filterable]="true" [editable]="true" [sortable]="true" [visibleWhenCollapsed]= 'true' field="FullAddress"></igx-column>
</igx-column-group> |
… that all children have pinned property set on initialization
…roup should remain pinned)
skrustev
approved these changes
Feb 8, 2024
mddragnev
added a commit
that referenced
this pull request
Feb 12, 2024
14 tasks
dkamburov
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
grid: column-pinning
grid: multi-column-headers
version: 17.1.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are dynamically rendered ot the collection is changed
Closes #13843
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)