Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hgrid): expose grid instance in template context #13996

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Mar 18, 2024

Closes #13976

Sample for verification

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

MayaKirova
MayaKirova previously approved these changes Mar 18, 2024
Copy link
Contributor

@MayaKirova MayaKirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm just wondering if it would be better to add this context to all grids for consistency.

@IMinchev64 IMinchev64 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Mar 19, 2024
@kdinev kdinev merged commit bf1ea6f into master Mar 25, 2024
6 checks passed
@kdinev kdinev deleted the bpachilova/fix-13976 branch March 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: hierarchical-grid version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

igxHierarchicalGrid: Add a property that holds a parent record data to the emptyGridTemplate's context.
5 participants