feat(badge): implement typography #14001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SisIvanova
added
badge
simeonoff
reviewed
Mar 20, 2024
Comment on lines
+1457
to
+1460
| @if $variant == 'indigo-design' { | ||
| %form-group-input--search { | ||
| padding-inline: pad-inline(rem(6px), rem(8px), rem(10px)); | ||
| } |
There was a problem hiding this comment.
Is this intentional in the PR or is it a left over from another branch? I see that this PR specifically introduces changes to the badge typography.
There was a problem hiding this comment.
Yes, it is intentional. It fixes a bug introduced with the Indigo design changes PR (#13948). If needed I will make a separate PR for this.
simeonoff
approved these changes
Mar 20, 2024
simeonoff
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)