Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): add pointer move handling; clear old HammerJS pan event. #14052

Merged
merged 8 commits into from
Apr 8, 2024
Merged

fix(slider): add pointer move handling; clear old HammerJS pan event. #14052

merged 8 commits into from
Apr 8, 2024

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Apr 3, 2024 •
edited

Closes #14036

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova self-assigned this Apr 5, 2024
@MayaKirova MayaKirova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 5, 2024
dkamburov
dkamburov previously approved these changes Apr 5, 2024
View reviewed changes
@damyanpetev damyanpetev mentioned this pull request Apr 5, 2024
Merged
@skrustev skrustev added the squash-merge Merge PR with "Squash and Merge" option label Apr 8, 2024
@skrustev skrustev changed the base branch from master to 17.1.x April 8, 2024 08:41
@damyanpetev damyanpetev changed the title fix(slider): Add pointer move handling for slider. Clear old HammerJS pan event. fix(slider): add pointer move handling; clear old HammerJS pan event. Apr 8, 2024
@damyanpetev damyanpetev merged commit 0a7c5d3 into 17.1.x Apr 8, 2024
3 of 4 checks passed
@damyanpetev damyanpetev deleted the skrastev/fix-14036 branch April 8, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@dkamburov dkamburov dkamburov left review comments

Assignees

@dkamburov dkamburov

@MayaKirova MayaKirova

Labels
slider squash-merge Merge PR with "Squash and Merge" option version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slider doesn't slide
5 participants
@skrustev @dkamburov @damyanpetev @MayaKirova @kdinev