fix(esf): reset forOf startIndex on esf columnChange #14125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlyexeption
added
❌ status: awaiting-test
MayaKirova
reviewed
Apr 18, 2024
| @@ -229,6 +229,10 @@ export class IgxExcelStyleSearchComponent implements AfterViewInit, OnDestroy { | |||
| }); | |||
| esf.columnChange.pipe(takeUntil(this.destroy$)).subscribe(() => { | |||
| this.virtDir?.resetScrollPosition(); | |||
|
|
|||
| if (this.virtDir) { | |||
| this.virtDir.state.startIndex = 0; | |||
There was a problem hiding this comment.
I'm not sure why this is necessary. Is perhaps the scrollbar already hidden at the time you are trying to reset it?
I also cannot reproduce the issue as is described in the original issue steps in 17.1.x:
Am I perhaps missing something or are steps slightly different?
There was a problem hiding this comment.
You can reproduce the issue in the ESF templates sample below.
Since we're reusing the IgxGridExcelStyleFilteringComponent and we do not reset the startIndex anymore (from #13688), it doesnt reset when changing the column.
screen-capture.webm
Notice how the startIndex of the second column is 14.
MayaKirova
requested changes
Apr 19, 2024
teodosiah
added
💥 status: in-test
gedinakova
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14043
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)